Replies: 0
Hi, there seem to be quite a few issues coming out of the latest updates.
1) one class of issue seems to be related to shortcodes, a brief analysis suggests Yoast may be trying to expand shortcodes during its evaluation of the post content, and some plugins aren’t expecting to be evaluated in admin mode and fail, this seems to be fixable on plugin basis, but could also be avoidable with some option on the Yoast end to not do this..
2) there are some other general warnings generated in unexpected circumstances.
For example this occurs on a editing a product in WooCommerce:
[10-Jul-2017 04:33:36 UTC] PHP Notice: Trying to get property of non-object in /wp-includes/class-wp-term-query.php on line 735
[10-Jul-2017 04:33:36 UTC] PHP Stack trace:
[10-Jul-2017 04:33:36 UTC] PHP 1. {main}() /wp-admin/post.php:0
[10-Jul-2017 04:33:36 UTC] PHP 2. include() /wp-admin/post.php:173
[10-Jul-2017 04:33:36 UTC] PHP 3. require_once() /wp-admin/edit-form-advanced.php:472
[10-Jul-2017 04:33:36 UTC] PHP 4. do_action($tag = *uninitialized*, $arg = *uninitialized*) /wp-admin/admin-header.php:97
[10-Jul-2017 04:33:36 UTC] PHP 5. WP_Hook->do_action($args = *uninitialized*) /wp-includes/plugin.php:453
[10-Jul-2017 04:33:36 UTC] PHP 6. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /wp-includes/class-wp-hook.php:323
[10-Jul-2017 04:33:36 UTC] PHP 7. WPSEO_Primary_Term_Admin->enqueue_assets(*uninitialized*) /wp-includes/class-wp-hook.php:298
[10-Jul-2017 04:33:36 UTC] PHP 8. array_map(*uninitialized*, *uninitialized*) /wp-content/plugins/wordpress-seo/admin/class-primary-term-admin.php:68
[10-Jul-2017 04:33:36 UTC] PHP 9. WPSEO_Primary_Term_Admin->map_taxonomies_for_js($taxonomy = *uninitialized*) /wp-content/plugins/wordpress-seo/admin/class-primary-term-admin.php:68
[10-Jul-2017 04:33:36 UTC] PHP 10. get_terms($args = *uninitialized*, $deprecated = *uninitialized*) /wp-content/plugins/wordpress-seo/admin/class-primary-term-admin.php:198
[10-Jul-2017 04:33:36 UTC] PHP 11. WP_Term_Query->query($query = *uninitialized*) /wp-includes/taxonomy.php:1084
[10-Jul-2017 04:33:36 UTC] PHP 12. WP_Term_Query->get_terms() /wp-includes/class-wp-term-query.php:294
Clearly the products do indeed have additional term types, and I understand this could be categorized a plugin related issue but turning off woocommerce and related plugins is not a feasible solution. Also this is not some erroneous behaviour caused by installing a new plugin, it is specific new functionality introduced by Yoast SEO.
I would just like to understand what Yoast SEO is attempting to do with WPSEO_Primary_Term_Admin map_taxonomies_for_js etc
.. well it looks like generate_primary_term_taxonomies is trying to get all the taxonomies, to allow the user to choose from these for primary term. Maybe this doesn’t apply to certain types of taxonomies like Product Attributes which effectively have a second level of indirection when compared to a standard taxonomy like Category and Tag.
However, I can’t see any Yoast functionality related to taxonomies in the user interface, even on a standard Post page where I can get the Yoast panel to appear.. Is this Pro functionality that is leaking into the standard component?